Skip to content

build: clean up some internal deprecated API usages #21342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 14, 2020
Merged

build: clean up some internal deprecated API usages #21342

merged 1 commit into from
Dec 14, 2020

Conversation

crisbeto
Copy link
Member

  • Replaces usages of the deprecated browser.rootEl with browser.angularAppRoot.
  • Fixes a couple of places that were using async instead of waitForAsync.

@crisbeto
build: clean up some internal deprecated API usages
ca659a8 
* Replaces usages of the deprecated `browser.rootEl` with `browser.angularAppRoot`.
* Fixes a couple of places that were using `async` instead of `waitForAsync`.
@crisbeto crisbeto added merge safe P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release labels Dec 13, 2020
@crisbeto crisbeto requested review from jelbourn and a team as code owners December 13, 2020 14:38
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 13, 2020
wagnermaciel
wagnermaciel approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@wagnermaciel wagnermaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Dec 14, 2020
@mmalerba mmalerba merged commit 6a99a8d into angular:master Dec 14, 2020
mmalerba pushed a commit that referenced this pull request Dec 14, 2020
@crisbeto @mmalerba
build: clean up some internal deprecated API usages (#21342)
413b7b3 
* Replaces usages of the deprecated `browser.rootEl` with `browser.angularAppRoot`.
* Fixes a couple of places that were using `async` instead of `waitForAsync`.

(cherry picked from commit 6a99a8d)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wagnermaciel wagnermaciel wagnermaciel approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@wagnermaciel wagnermaciel

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @wagnermaciel @mmalerba