build: fix not being able to test MDC density in RTL #21398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our dev app is set up so that the density styles are set on the `body` while the `dir` is set only around the content. The problem is that MDC's mixins output density styles for RTL in the format `[dir='rtl'] .density .foo` which means that the directionality has to be a level above the density class or we won't get an accurate representation of how the components look. This threw me off for a while earlier today, because I noticed that the MDC slide toggle didn't behave correctly in RTL. These changes fix the issue by moving the `dir` a level up and applying the density class in a couple of places.
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
annieyw
pushed a commit
that referenced
this pull request
Jan 7, 2021
Our dev app is set up so that the density styles are set on the `body` while the `dir` is set only around the content. The problem is that MDC's mixins output density styles for RTL in the format `[dir='rtl'] .density .foo` which means that the directionality has to be a level above the density class or we won't get an accurate representation of how the components look. This threw me off for a while earlier today, because I noticed that the MDC slide toggle didn't behave correctly in RTL. These changes fix the issue by moving the `dir` a level up and applying the density class in a couple of places. (cherry picked from commit 69b0a72)
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Jan 14, 2021
Our dev app is set up so that the density styles are set on the `body` while the `dir` is set only around the content. The problem is that MDC's mixins output density styles for RTL in the format `[dir='rtl'] .density .foo` which means that the directionality has to be a level above the density class or we won't get an accurate representation of how the components look. This threw me off for a while earlier today, because I noticed that the MDC slide toggle didn't behave correctly in RTL. These changes fix the issue by moving the `dir` a level up and applying the density class in a couple of places.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our dev app is set up so that the density styles are set on the
bodywhile thediris set only around the content. The problem is that MDC's mixins output density styles for RTL in the format[dir='rtl'] .density .foowhich means that the directionality has to be a level above the density class or we won't get an accurate representation of how the components look. This threw me off for a while earlier today, because I noticed that the MDC slide toggle didn't behave correctly in RTL.These changes fix the issue by moving the
dira level up and applying the density class in a couple of places.