fix(cdk/overlay): sub-pixel deviations throwing off positioning in some cases #21427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
crisbeto
force-pushed
the
21350/zoomed-in-overlay
branch
2 times, most recently
from
743c39f to
13c7e47
Compare
…me cases If the browser is zoomed in beyond the default level, it may report numbers with sub-pixel deviations to `getBoundingClientRect` (e.g. 100.09 vs 100) which can throw off our logic when comparing against the viewport size which is always a whole number. These changes fix the issue by rounding down the numbers that we get from `getBoundingClientRect`. Fixes angular#21350.
crisbeto
force-pushed
the
21350/zoomed-in-overlay
branch
from
13c7e47 to
19b9b4c
Compare
jelbourn
approved these changes
Jan 5, 2021
| * deviations in the `ClientRect` returned by the browser (e.g. when zoomed in with a percentage | ||
| * size, see #21350). | ||
| */ | ||
| function getRoundedBoundingClientRect(clientRect: ClientRect): ClientRect { |
There was a problem hiding this comment.
It just rolls right off the tongue
mmalerba
pushed a commit
that referenced
this pull request
Jan 15, 2021
…me cases (#21427) If the browser is zoomed in beyond the default level, it may report numbers with sub-pixel deviations to `getBoundingClientRect` (e.g. 100.09 vs 100) which can throw off our logic when comparing against the viewport size which is always a whole number. These changes fix the issue by rounding down the numbers that we get from `getBoundingClientRect`. Fixes #21350. (cherry picked from commit 0c8cfa7)
mmalerba
pushed a commit
that referenced
this pull request
Jan 15, 2021
…me cases (#21427) If the browser is zoomed in beyond the default level, it may report numbers with sub-pixel deviations to `getBoundingClientRect` (e.g. 100.09 vs 100) which can throw off our logic when comparing against the viewport size which is always a whole number. These changes fix the issue by rounding down the numbers that we get from `getBoundingClientRect`. Fixes #21350. (cherry picked from commit 0c8cfa7)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the browser is zoomed in beyond the default level, it may report numbers with sub-pixel deviations to
getBoundingClientRect(e.g. 100.09 vs 100) which can throw off our logic when comparing against the viewport size which is always a whole number.These changes fix the issue by rounding down the numbers that we get from
getBoundingClientRect.Fixes #21350.