Skip to content

build: update to gulp 4 #21445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2021
Merged

build: update to gulp 4 #21445

merged 1 commit into from
Jan 7, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Dec 27, 2020

We still depend on Gulp for a couple of CI tasks, but we've been stuck on version 3.8 for a while which doesn't support Node 12 (without workarounds) and might break in other ways in the future.

These changes update us to version 4.0.2, account for the breaking changes and remove some dependencies that have been replaced by functions in Gulp.

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 27, 2020
We still depend on Gulp for a couple of CI tasks, but we've been stuck on version 3.8 for
a while which doesn't support Node 12 and might break in other ways in the future.

These changes update us to version 4.0.2, account for the breaking changes and remove
some dependencies that have been replaced by functions in Gulp.
@crisbeto crisbeto marked this pull request as ready for review December 27, 2020 11:07
@crisbeto crisbeto requested a review from a team as a code owner December 27, 2020 11:07
@crisbeto crisbeto added merge safe P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Dec 27, 2020
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Jan 5, 2021
@annieyw annieyw added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jan 7, 2021
@annieyw annieyw merged commit 6c1001f into angular:master Jan 7, 2021
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Jan 14, 2021
We still depend on Gulp for a couple of CI tasks, but we've been stuck on version 3.8 for
a while which doesn't support Node 12 and might break in other ways in the future.

These changes update us to version 4.0.2, account for the breaking changes and remove
some dependencies that have been replaced by functions in Gulp.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants