Skip to content

fix(material-experimental/mdc-form-field): fill appearance blending in with the background in high contrast mode #21446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2021
Merged

fix(material-experimental/mdc-form-field): fill appearance blending in with the background in high contrast mode #21446

merged 1 commit into from
Jan 9, 2021

Conversation

crisbeto
Copy link
Member

The outline of the fill appearance is done through a background color which will blend in with the background in high contrast mode. These changes add an outline to replace it.

@crisbeto
fix(material-experimental/mdc-form-field): fill appearance blending i…
e56802a 
…n with the background in high contrast mode

The outline of the `fill` appearance is done through a background color which will blend
in with the background in high contrast mode. These changes add an outline to replace it.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Dec 27, 2020
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 27, 2020
@crisbeto crisbeto added the Accessibility This issue is related to accessibility (a11y) label Dec 31, 2020
mmalerba
mmalerba approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Jan 5, 2021
@annieyw annieyw merged commit 3aa5527 into angular:master Jan 9, 2021
annieyw pushed a commit that referenced this pull request Jan 9, 2021
@crisbeto @annieyw
fix(material-experimental/mdc-form-field): fill appearance blending i…
a0adffd 
…n with the background in high contrast mode (#21446)

The outline of the `fill` appearance is done through a background color which will blend
in with the background in high contrast mode. These changes add an outline to replace it.

(cherry picked from commit 3aa5527)
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Jan 14, 2021
@crisbeto @wagnermaciel
fix(material-experimental/mdc-form-field): fill appearance blending i…
da6a779 
…n with the background in high contrast mode (angular#21446)

The outline of the `fill` appearance is done through a background color which will blend
in with the background in high contrast mode. These changes add an outline to replace it.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

@devversion devversion Awaiting requested review from devversion

Assignees

@mmalerba mmalerba

Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @mmalerba @annieyw