Skip to content

docs(material/menu): add harness example for menu #21451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2021
Merged

docs(material/menu): add harness example for menu #21451

merged 1 commit into from
Jan 6, 2021

Conversation

annieyw
Copy link
Contributor

@annieyw annieyw commented Dec 28, 2020

No description provided.

@annieyw annieyw added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent docs This issue is related to documentation merge safe target: patch This PR is targeted for the next patch release labels Dec 28, 2020
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 28, 2020
@annieyw annieyw force-pushed the menu-harness-example branch from dbc784c to 2b860a5 Compare December 28, 2020 05:54
crisbeto
crisbeto approved these changes Dec 29, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can be marked as ready when the comments are addressed.

@annieyw annieyw force-pushed the menu-harness-example branch from 2b860a5 to 724c0d6 Compare December 29, 2020 06:48
@annieyw annieyw added action: merge The PR is ready for merge by the caretaker and removed action: merge The PR is ready for merge by the caretaker labels Dec 29, 2020
@annieyw annieyw force-pushed the menu-harness-example branch from 724c0d6 to 99e5c9a Compare December 30, 2020 07:37
@annieyw annieyw added the action: merge The PR is ready for merge by the caretaker label Jan 5, 2021
@annieyw annieyw merged commit f823198 into angular:master Jan 6, 2021
annieyw added a commit that referenced this pull request Jan 6, 2021
@annieyw
docs(material/menu): add harness example for menu (#21451)
218158c 
(cherry picked from commit f823198)
@annieyw annieyw deleted the menu-harness-example branch January 6, 2021 11:47
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Jan 14, 2021
@annieyw @wagnermaciel
docs(material/menu): add harness example for menu (angular#21451)
883624b
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annieyw @crisbeto