docs(material/select): add harness example for select #21464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annieyw
added
P3
google-cla
bot
added
the
cla: yes
crisbeto
approved these changes
Dec 30, 2020
| // Angular won't call this for us so we need to do it ourselves to avoid leaks. | ||
| overlayContainer.ngOnDestroy(); | ||
| overlayContainer = null!; | ||
| }); |
There was a problem hiding this comment.
We can drop this afterEach and the dependency on the OverlayContainer since it was added primarily for our own unit tests.
| @@ -0,0 +1,21 @@ | |||
| import {Component} from '@angular/core'; | |||
|
|
|||
| interface Food { | |||
There was a problem hiding this comment.
I think that you can remove this interface, TS will infer the type itself.
annieyw
force-pushed
the
select-harness-example
branch
from
6b414dc to
d39061b
Compare
annieyw
force-pushed
the
select-harness-example
branch
from
d39061b to
95ddae9
Compare
annieyw
added a commit
that referenced
this pull request
Jan 6, 2021
(cherry picked from commit dc5b773)
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Jan 14, 2021
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.