Skip to content

build: fix compilation errors in utility scripts #21488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/dev-server/dev-server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export class DevServer {

/** Starts the server on the given port. */
async start() {
return new Promise((resolve, reject) => {
return new Promise<void>((resolve, reject) => {
this.server.init(this.options, (err) => {
if (err) {
reject(err);
Expand Down
2 changes: 1 addition & 1 deletion tools/release/changelog.ts
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export async function prependChangelogFromLatestTag(changelogPath: string, relea
// actually prepend the new changelog to the existing one.
const previousChangelogStream = createReadStream(changelogPath);

return new Promise((resolve, reject) => {
return new Promise<void>((resolve, reject) => {
// Sequentially merge the changelog output and the previous changelog stream, so that
// the new changelog section comes before the existing versions. Afterwards, pipe into the
// changelog file, so that the changes are reflected on file system.
Expand Down
2 changes: 1 addition & 1 deletion tools/release/release-output/check-package.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export function checkReleasePackage(
releasesPath: string, packageName: string, expectedVersion: string): boolean {
const packagePath = join(releasesPath, packageName);
const failures = new Map() as PackageFailures;
const addFailure = (message, filePath?) => {
const addFailure = (message: string, filePath?: string) => {
const filePaths = failures.get(message) || [];
if (filePath) {
filePaths.push(filePath);
Expand Down