refactor(material-experimental/mdc-checkbox): de-duplicate test harness logic #21506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
crisbeto
requested review from
devversion,
jelbourn,
mmalerba and
a team
as code owners
google-cla
bot
added
the
cla: yes
crisbeto
force-pushed
the
checkbox-harness-cleanup
branch
from
681002a to
90e558a
Compare
…ss logic Refactors the MDC checkbox harness so that it extends the non-MDC one directly, because most of the logic is identical.
crisbeto
force-pushed
the
checkbox-harness-cleanup
branch
from
90e558a to
28ce8e7
Compare
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Jan 26, 2021
…ss logic (angular#21506) Refactors the MDC checkbox harness so that it extends the non-MDC one directly, because most of the logic is identical.
mmalerba
pushed a commit
to mmalerba/components
that referenced
this pull request
Jan 29, 2021
…ss logic (angular#21506) Refactors the MDC checkbox harness so that it extends the non-MDC one directly, because most of the logic is identical.
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Feb 8, 2021
…ss logic (angular#21506) Refactors the MDC checkbox harness so that it extends the non-MDC one directly, because most of the logic is identical.
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Feb 8, 2021
…ss logic (angular#21506) Refactors the MDC checkbox harness so that it extends the non-MDC one directly, because most of the logic is identical.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the MDC checkbox harness so that it extends the non-MDC one directly, because most of the logic is identical.