Skip to content

fix(material/autocomplete): activate first enabled option with autoActiveFirstOption #21513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jan 7, 2021

Currently the autocomplete trigger will activate the first option when autoActiveFirstOption, no matter whether it is disabled. These changes use a different API which will allow us to pick the first enabled option.

Fixes #21498.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jan 7, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 7, 2021
…tiveFirstOption

Currently the autocomplete trigger will activate the first option when `autoActiveFirstOption`,
no matter whether it is disabled. These changes use a different API which will allow us to
pick the first enabled option.

Fixes angular#21498.
@crisbeto crisbeto force-pushed the 21498/autocomplete-auto-active-disabled branch from db078f9 to 2cc60ae Compare January 7, 2021 12:59
@annieyw annieyw added the action: merge The PR is ready for merge by the caretaker label Jan 7, 2021
@mmalerba mmalerba merged commit f4436e2 into angular:master Jan 14, 2021
mmalerba pushed a commit that referenced this pull request Jan 14, 2021
…tiveFirstOption (#21513)

Currently the autocomplete trigger will activate the first option when `autoActiveFirstOption`,
no matter whether it is disabled. These changes use a different API which will allow us to
pick the first enabled option.

Fixes #21498.

(cherry picked from commit f4436e2)
mmalerba pushed a commit that referenced this pull request Jan 14, 2021
…tiveFirstOption (#21513)

Currently the autocomplete trigger will activate the first option when `autoActiveFirstOption`,
no matter whether it is disabled. These changes use a different API which will allow us to
pick the first enabled option.

Fixes #21498.

(cherry picked from commit f4436e2)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(mat-autocomplete): autoActiveFirstOption selects disabled <mat-option>
3 participants