Skip to content

refactor(material-experimental/mdc-paginator): de-duplicate test harness logic #21519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jan 8, 2021

Changes the MDC-based MatPaginatorHarness to extend the non-MDC version since the logic is identical, apart from a few selectors.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jan 8, 2021
@crisbeto crisbeto requested review from andrewseguin and a team as code owners January 8, 2021 13:48
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 8, 2021
Copy link
Contributor

@andrewseguin andrewseguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Jan 8, 2021
@crisbeto crisbeto force-pushed the paginator-harness-cleanup branch from 83a7eaa to 88244d8 Compare January 22, 2021 17:32
…ess logic

Changes the MDC-based `MatPaginatorHarness` to extend the non-MDC version since
the logic is identical, apart from a few selectors.
@crisbeto crisbeto force-pushed the paginator-harness-cleanup branch from 88244d8 to 5562305 Compare January 22, 2021 17:40
@andrewseguin andrewseguin merged commit 3269dae into angular:master Jan 25, 2021
andrewseguin pushed a commit that referenced this pull request Jan 25, 2021
…ess logic (#21519)

Changes the MDC-based `MatPaginatorHarness` to extend the non-MDC version since
the logic is identical, apart from a few selectors.

(cherry picked from commit 3269dae)
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Jan 26, 2021
…ess logic (angular#21519)

Changes the MDC-based `MatPaginatorHarness` to extend the non-MDC version since
the logic is identical, apart from a few selectors.
mmalerba pushed a commit to mmalerba/components that referenced this pull request Jan 29, 2021
…ess logic (angular#21519)

Changes the MDC-based `MatPaginatorHarness` to extend the non-MDC version since
the logic is identical, apart from a few selectors.
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Feb 8, 2021
…ess logic (angular#21519)

Changes the MDC-based `MatPaginatorHarness` to extend the non-MDC version since
the logic is identical, apart from a few selectors.
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Feb 8, 2021
…ess logic (angular#21519)

Changes the MDC-based `MatPaginatorHarness` to extend the non-MDC version since
the logic is identical, apart from a few selectors.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants