Skip to content

build: update to rules_nodejs 2.3.2 #21528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2021
Merged

build: update to rules_nodejs 2.3.2 #21528

merged 1 commit into from
Jan 15, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jan 9, 2021

Updates rules_nodejs and related dependencies to 2.3.2 as a precursor to updating to 3.0. Relates to angular/angular#40367.

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 9, 2021
@crisbeto crisbeto marked this pull request as ready for review January 9, 2021 18:32
@crisbeto crisbeto requested a review from a team as a code owner January 9, 2021 18:32
@crisbeto crisbeto added merge safe P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jan 9, 2021
@crisbeto
build: update to rules_nodejs 2.3.2
18c84e5 
Updates `rules_nodejs` and related dependencies to 2.3.2 as a precursor to updating to 3.0.
Relates to angular/angular#40367.
josephperrott
josephperrott approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Jan 12, 2021
@josephperrott
Copy link
Member

Caretaker Note: While this has been tested locally against windows, there have been issues with landing this rules_nodejs update in framework related to windows linker.

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jan 12, 2021
@mmalerba mmalerba added target: rc This PR is targeted for the next release-candidate and removed target: patch This PR is targeted for the next patch release labels Jan 15, 2021
@mmalerba mmalerba merged commit 6f06f96 into angular:master Jan 15, 2021
mmalerba pushed a commit that referenced this pull request Jan 15, 2021
@crisbeto @mmalerba
build: update to rules_nodejs 2.3.2 (#21528)
e1ec7d0 
Updates `rules_nodejs` and related dependencies to 2.3.2 as a precursor to updating to 3.0.
Relates to angular/angular#40367.

(cherry picked from commit 6f06f96)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

Assignees

@josephperrott josephperrott

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @josephperrott @mmalerba