build: replace deprecated axe dependency #21534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
crisbeto
force-pushed
the
axe-bump
branch
5 times, most recently
from
2e72df1 to
54fb5e0
Compare
The `axe-webdriverjs` package was deprecated in favor of `@axe-core/webdriverjs`. These changes switch to the new package, fix the new failures that were picked up and clean up some repetitive code.
crisbeto
requested review from
annieyw,
jelbourn,
mmalerba and
a team
as code owners
crisbeto
added
merge safe
P3
jelbourn
reviewed
Jan 11, 2021
| @@ -1,6 +1,6 @@ | |||
| <section class="demo-virtual-scroll-uniform-size"> | |||
| <h3>Uniform size</h3> | |||
| <cdk-virtual-scroll-viewport class="demo-viewport" autosize> | |||
| <cdk-virtual-scroll-viewport class="demo-viewport" autosize tabindex="0"> | |||
There was a problem hiding this comment.
Axe complains that scrollable areas need to have tab stops.
jelbourn
approved these changes
Jan 11, 2021
|
For what it's worth, it's what I had tried to tackle in #14808. |
|
Right, I didn't think of that; it way indexed in my brain under "tabs". |
mmalerba
added
target: minor
|
bumping to minor due to conflicts on patch branch |
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Jan 14, 2021
The `axe-webdriverjs` package was deprecated in favor of `@axe-core/webdriverjs`. These changes switch to the new package, fix the new failures that were picked up and clean up some repetitive code.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
axe-webdriverjspackage was deprecated in favor of@axe-core/webdriverjs. These changes switch to the new package, fix the new failures that were picked up and clean up some repetitive code.