docs(material/sidenav): add sidenav harness example #21788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annieyw
added
P3
google-cla
bot
added
the
cla: yes
annieyw
force-pushed
the
sidenav-example
branch
3 times, most recently
from
0bbd54f to
a022c8d
Compare
crisbeto
approved these changes
Feb 3, 2021
| import {SidenavHarnessExample} from './sidenav-harness-example'; | ||
| import {NoopAnimationsModule} from '@angular/platform-browser/animations'; | ||
|
|
||
| describe('DrawerHarnessExample', () => { |
There was a problem hiding this comment.
This says that it's the drawer harness, but we're using the sidenav harness everywhere.
| import {Component} from '@angular/core'; | ||
|
|
||
| /** | ||
| * @title Testing with MatDrawerHarness |
There was a problem hiding this comment.
Inconsistent naming here as well.
annieyw
force-pushed
the
sidenav-example
branch
from
a022c8d to
4e275e0
Compare
annieyw
added
action: merge
annieyw
added a commit
that referenced
this pull request
Feb 5, 2021
(cherry picked from commit 47ea05d)
annieyw
added a commit
that referenced
this pull request
Feb 5, 2021
(cherry picked from commit 47ea05d)
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Feb 8, 2021
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Feb 8, 2021
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.