build: set up generic way of passing in environment variables to dev app

[crisbeto]

Currently we have a one-off way of passing the Google Maps API key to the dev app. These changes rework the approach so that we have a single variables.json file which can be used for the Google Maps key, as well as any other variables in the future.

[crisbeto]

@mbehrlich once these changes land, you'll have to change your google-maps-api-key.txt to variables.json with the following content:

{
  "GOOGLE_MAPS_KEY": "{{your key}}"
}

[crisbeto]

@josephperrott I don't know how to resolve the lint errors in this file. I get a lint failure even after I run yarn format and the error doesn't actually say what's wrong. Here's the full log:

yarn run v1.22.10
Checking format of 1 file(s)

The following files are out of format:
    - src/dev-app/BUILD.bazel

? Format the files now? Yes
Formatting 1 file(s)
[========================================] ETA: 0s | 1/1 files
√  Formatting complete.
Done in 5.56s.

[josephperrott]

This issue was actually just reported a few days ago in another case. I need to address the error messaging that occurs to surface it.

For the specific situation, you can have a glob without a matcher.

You should instead have

filegroup(
    name = "variables",
    srcs = [
        "variables.json"
    ],
)

[crisbeto]

The problem is that the variables.json is an optional file that is .gitignored. Wouldn't using a filegroup like this result in an error if the file doesn't exist?

[mbehrlich]

I think I ran into this problem too. You need the glob, because the file doesn't necessarily exist, but it needs some arbitrary matcher because of the lint issue, I assume due to the assumption that you would never need a glob for a single file.

[crisbeto]

Nice, adding a * in there fixed it 👍

[jelbourn]

LGTM

[josephperrott]

LGTM

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}