Skip to content

feat(material-experimental/mdc-tooltip): add test harness #21855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2021
Merged

feat(material-experimental/mdc-tooltip): add test harness #21855

merged 1 commit into from
Feb 12, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Feb 9, 2021

Sets up a test harness for the MDC-based tooltip.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release labels Feb 9, 2021
@crisbeto crisbeto requested review from andrewseguin, jelbourn and a team as code owners February 9, 2021 19:28
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 9, 2021
mmalerba
mmalerba approved these changes Feb 9, 2021
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto
feat(material-experimental/mdc-tooltip): add test harness
fea3d8b 
Sets up a test harness for the MDC-based tooltip.
@crisbeto crisbeto force-pushed the mdc-tooltip-harness branch from f3c1546 to fea3d8b Compare February 9, 2021 20:21
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Feb 9, 2021
@mmalerba mmalerba merged commit 5e4d5e0 into angular:master Feb 12, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crisbeto @mmalerba