Skip to content

fix(material-experimental/mdc-typography): strip typography properties #21878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 18, 2021
Merged

fix(material-experimental/mdc-typography): strip typography properties #21878

merged 2 commits into from
Feb 18, 2021

Conversation

mmalerba
Copy link
Contributor

with null value

This fixes an issue with MDC emitting CSS variables with no fallback value.

@mmalerba mmalerba added P2 The issue is important to a large percentage of users, with a workaround G This is is related to a Google internal issue target: patch This PR is targeted for the next patch release labels Feb 11, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 11, 2021
crisbeto
crisbeto approved these changes Feb 12, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Feb 12, 2021
@andrewseguin andrewseguin merged commit 07eb0f7 into angular:master Feb 18, 2021
andrewseguin pushed a commit that referenced this pull request Feb 18, 2021
@mmalerba @andrewseguin
fix(material-experimental/mdc-typography): strip typography properties (
762a537 
#21878)

* fix(material-experimental/mdc-typography): strip typography properties
with null value

* fixup! fix(material-experimental/mdc-typography): strip typography properties with null value

(cherry picked from commit 07eb0f7)
andrewseguin added a commit that referenced this pull request Feb 19, 2021
@andrewseguin
Revert "fix(material-experimental/mdc-typography): strip typography p…
06db8c3 
…roperties (#21878)"

This reverts commit 07eb0f7.
@andrewseguin andrewseguin mentioned this pull request Feb 19, 2021
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees

@annieyw annieyw

@wagnermaciel wagnermaciel

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mmalerba @crisbeto @annieyw @andrewseguin @wagnermaciel