Skip to content

fix(material-experimental/mdc-select): fix floating label behavior #22134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2021

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Mar 5, 2021

No description provided.

@mmalerba mmalerba requested a review from crisbeto as a code owner March 5, 2021 21:50
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 5, 2021
@mmalerba mmalerba added P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Mar 5, 2021
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changes are fine, but I implemented it this way on purpose. I always found it weird that the label floats, even though we have nothing to show in its place. It wasn't as noticeable on the old select since the overlay was on top of the label most of the time, but that's not the case for the MDC one.

@mmalerba
Copy link
Contributor Author

mmalerba commented Mar 8, 2021

I'm just going for consistency with the MDC one. This is what the MDC one does, though we could bring up with them whether this is what it should do.

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Mar 11, 2021
@andrewseguin andrewseguin merged commit 16b7adb into angular:master Mar 19, 2021
andrewseguin pushed a commit that referenced this pull request Mar 19, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants