-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(material/progress-bar): fix screenreader not reading aria-label #22201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I tested this in the dev app and the value updates fine but for some reason the unit test is failing, any ideas? |
Commenting here for posterity: Annie and I chatted about this change and we're going to look into changing to a solution that will let people keep using the actual ARIA attributes rather than introducing new properties (which we can then apply to other components) |
38d93a8
to
913046b
Compare
Update: |
added comments to explain change and note about FireFox/JAWS issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes issue with NVDA/FIreFox not reading out aria-label (when set)
Fixes #15017
Note that this does not fix the issue for JAWS/FireFox (FreedomScientific/standards-support#354)