Skip to content

fix(material/progress-bar): fix screenreader not reading aria-label #22201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 2, 2021

Conversation

annieyw
Copy link
Contributor

@annieyw annieyw commented Mar 12, 2021

Fixes issue with NVDA/FIreFox not reading out aria-label (when set)
Fixes #15017

Note that this does not fix the issue for JAWS/FireFox (FreedomScientific/standards-support#354)

@annieyw annieyw added P2 The issue is important to a large percentage of users, with a workaround Accessibility This issue is related to accessibility (a11y) target: patch This PR is targeted for the next patch release labels Mar 12, 2021
@annieyw annieyw requested review from jelbourn and crisbeto March 12, 2021 04:13
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 12, 2021
@annieyw
Copy link
Contributor Author

annieyw commented Mar 12, 2021

I tested this in the dev app and the value updates fine but for some reason the unit test is failing, any ideas?

@annieyw annieyw removed request for jelbourn and crisbeto March 12, 2021 17:13
@jelbourn
Copy link
Member

Commenting here for posterity: Annie and I chatted about this change and we're going to look into changing to a solution that will let people keep using the actual ARIA attributes rather than introducing new properties (which we can then apply to other components)

@annieyw annieyw force-pushed the progress-bar-aria branch from 38d93a8 to 913046b Compare March 22, 2021 21:33
@annieyw annieyw requested a review from andrewseguin as a code owner March 22, 2021 21:33
@annieyw annieyw changed the title fix(material/progress-bar): add accessible label for screen readers fix(material/progress-bar): fix screenreader not reading aria-label Mar 22, 2021
@annieyw
Copy link
Contributor Author

annieyw commented Mar 22, 2021

Update:
Instead of adding an accessible label we have decided to simply set tabindex to -1 for aria-label to work with most screen reader/ browser combos. (Note that there is a known issue with JAWS/FireFox.)

@annieyw
Copy link
Contributor Author

annieyw commented Mar 29, 2021

added comments to explain change and note about FireFox/JAWS issue

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Mar 31, 2021
@annieyw annieyw merged commit a9cdb08 into angular:master Apr 2, 2021
annieyw added a commit that referenced this pull request Apr 2, 2021
…22201)

* fix(material/progress-spinner): fix screenreader not reading out aria-label

* fixup! fix(material/progress-spinner): fix screenreader not reading out aria-label

(cherry picked from commit a9cdb08)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: progress bar and progress spinner examples are unreachable with NVDA and Firefox
2 participants