build: fix jasmine_node_test #22291
Merged
build: fix jasmine_node_test #22291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Bazel NodeJS rules 3.0.0 the require patching was removed by default, which was addressed in the upgrade to 3.2.1. However this was missed for jasmine_node_test, which now silently fails. This PR adds the bazel patch for the module resolver, which ensures spec files are found.
google-cla
bot
added
the
cla: yes
crisbeto
added
action: merge
andrewseguin
pushed a commit
that referenced
this pull request
Mar 19, 2021
With Bazel NodeJS rules 3.0.0 the require patching was removed by default, which was addressed in the upgrade to 3.2.1. However this was missed for jasmine_node_test, which now silently fails. This PR adds the bazel patch for the module resolver, which ensures spec files are found. (cherry picked from commit 5433fb0)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Bazel NodeJS rules 3.0.0 the require patching was removed by default,
which was addressed in the upgrade to 3.2.1. However this was missed for
jasmine_node_test, which now silently fails. This PR adds the bazel patch for
the module resolver, which ensures spec files are found.