Skip to content

refactor(material-experimental/mdc-core): expose new @use-based Sass API #22338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2021

Conversation

crisbeto
Copy link
Member

Implements an _index.scss file in material-experimental similar to the one in material.

Also fixes a couple of theme files that weren't named correctly and some mixins whose prefixes weren't removed by the migration script.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels Mar 24, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 24, 2021
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added action: merge The PR is ready for merge by the caretaker and removed action: merge The PR is ready for merge by the caretaker labels Mar 24, 2021
@crisbeto crisbeto force-pushed the experimental-index branch 2 times, most recently from b1e365b to 57dec57 Compare March 25, 2021 05:25
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Mar 25, 2021
Implements an `_index.scss` file in `material-experimental` similar to the one in `material`.

Also fixes a couple of theme files that weren't named correctly and some mixins whose prefixes weren't removed by the migration script.
@crisbeto crisbeto force-pushed the experimental-index branch from 57dec57 to 40d9bf9 Compare March 25, 2021 05:31
@crisbeto crisbeto requested a review from a team as a code owner March 25, 2021 05:31
@josephperrott josephperrott removed the request for review from a team March 25, 2021 15:35
@wagnermaciel wagnermaciel merged commit e829c22 into angular:master Mar 29, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants