feat(material/datepicker): remove dependency on dialog #22383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
crisbeto
added
P2
mmalerba
added
the
merge: fix commit message
|
@crisbeto please rebase |
crisbeto
force-pushed
the
datepicker-dialog-remove
branch
from
df6cc4b to
df9042d
Compare
Currently the datepicker has a hard dependency on `MatDialog` due to its touch-specific appearance which makes it difficult to use together with the MDC packages, because they have an alternate dialog module. These changes resolve the issue by removing the datepicker's dependency on `MatDialog`. The approach is loosely based on angular#13019, however I've simplified things a bit to make it more maintainable.
crisbeto
force-pushed
the
datepicker-dialog-remove
branch
from
df9042d to
18ca9b0
Compare
|
Rebased and fixed up the commit title. |
crisbeto
changed the title
crisbeto
removed
the
merge: fix commit message
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the datepicker has a hard dependency on
MatDialogdue to its touch-specific appearance which makes it difficult to use together with the MDC packages, because they have an alternate dialog module.These changes resolve the issue by removing the datepicker's dependency on
MatDialog. The approach is loosely based on #13019, however I've simplified things a bit to make it more maintainable.