Skip to content

build: bump a few Angular and external dependencies #22507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2021

Conversation

crisbeto
Copy link
Member

  • Bumps all of the Angular dependencies to 12.0.0-next.9.
  • Removes the logic related to entryComponents from the schematics code, because the CLI is in the process of removing ViewEngine and some of the options aren't there anymore.
  • Updates the versions of ts-node and kagekiri since we were a few minor versions behind.

Note: marking this as a P2, because of the changes related to entryComponents.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround merge safe target: rc This PR is targeted for the next release-candidate labels Apr 18, 2021
@crisbeto crisbeto requested a review from devversion April 18, 2021 10:12
@crisbeto crisbeto requested review from jelbourn and a team as code owners April 18, 2021 10:12
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 18, 2021
@crisbeto crisbeto force-pushed the ng-12-next-9-bump branch from f7f3f5f to 58b0d85 Compare April 18, 2021 10:24
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We can remove the .min.js UMD check that is failing. ng_package no longer generates those. angular/angular#41425

* Bumps all of the Angular dependencies to 12.0.0-next.9.
* Removes the logic related to `entryComponents` from the schematics code, because the CLI is in the process of removing ViewEngine and some of the options aren't there anymore.
* Updates the versions of `ts-node` and `kagekiri` since we were a few minor versions behind.
@crisbeto crisbeto force-pushed the ng-12-next-9-bump branch from 58b0d85 to 4044b65 Compare April 18, 2021 11:45
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Apr 18, 2021
@wagnermaciel wagnermaciel merged commit 4bcd76c into angular:master Apr 21, 2021
wagnermaciel pushed a commit that referenced this pull request Apr 21, 2021
* Bumps all of the Angular dependencies to 12.0.0-next.9.
* Removes the logic related to `entryComponents` from the schematics code, because the CLI is in the process of removing ViewEngine and some of the options aren't there anymore.
* Updates the versions of `ts-node` and `kagekiri` since we were a few minor versions behind.

(cherry picked from commit 4bcd76c)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants