Skip to content

docs: fill out jsdoc for button, checkbox, and radio #2252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 16, 2016

Conversation

jelbourn
Copy link
Member

I also renamed the radio's align values to before | after instead of start | end to be consistent with our naming scheme. I checked, and nobody inside Google is using those properties.

@jelbourn jelbourn requested a review from mmalerba December 16, 2016 17:27
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 16, 2016
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Dec 16, 2016
@mmalerba
Copy link
Contributor

lgtm

@jelbourn jelbourn merged commit 34642ea into angular:master Dec 16, 2016
@jelbourn jelbourn deleted the jsdocs1 branch September 13, 2017 04:35
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants