Skip to content

fix(material-experimental/mdc-card): reset native header margin #22550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

crisbeto
Copy link
Member

mat-card supports using native header elements for the title and subtitle, but doing so throws off the alignment, because we weren't clearing the user agent margin.

`mat-card` supports using native header elements for the title and subtitle, but doing so throws off the alignment, because we weren't clearing the user agent margin.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Apr 23, 2021
@crisbeto crisbeto requested a review from jelbourn April 23, 2021 15:44
@crisbeto crisbeto requested a review from mmalerba as a code owner April 23, 2021 15:44
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 23, 2021
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added action: merge The PR is ready for merge by the caretaker P2 The issue is important to a large percentage of users, with a workaround and removed P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Apr 26, 2021
@andrewseguin andrewseguin merged commit f88023c into angular:master Apr 27, 2021
andrewseguin pushed a commit that referenced this pull request Apr 27, 2021
`mat-card` supports using native header elements for the title and subtitle, but doing so throws off the alignment, because we weren't clearing the user agent margin.

(cherry picked from commit f88023c)
andrewseguin pushed a commit that referenced this pull request Apr 27, 2021
`mat-card` supports using native header elements for the title and subtitle, but doing so throws off the alignment, because we weren't clearing the user agent margin.

(cherry picked from commit f88023c)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants