fix(material/datepicker): support for date range input in MDC-based form field #22565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
google-cla
bot
added
the
cla: yes
crisbeto
changed the title
…orm field Resolves a few issues that were preventing the use of the range picker with an MDC-based `mat-form-field`. Including: 1. Conditionally setting the `mat-mdc-input-element` class so that the input is sized correctly. 2. Triggering a state change event when the focus state changes so that the floating label is up-to-date. 3. Fixing an error being thrown inside `_shouldHideSeparator`.
crisbeto
force-pushed
the
mdc-form-field-range-input
branch
from
7425147 to
d12eb89
Compare
andrewseguin
pushed a commit
that referenced
this pull request
Apr 27, 2021
…orm field (#22565) Resolves a few issues that were preventing the use of the range picker with an MDC-based `mat-form-field`. Including: 1. Conditionally setting the `mat-mdc-input-element` class so that the input is sized correctly. 2. Triggering a state change event when the focus state changes so that the floating label is up-to-date. 3. Fixing an error being thrown inside `_shouldHideSeparator`. (cherry picked from commit 355233d)
andrewseguin
pushed a commit
that referenced
this pull request
Apr 27, 2021
…orm field (#22565) Resolves a few issues that were preventing the use of the range picker with an MDC-based `mat-form-field`. Including: 1. Conditionally setting the `mat-mdc-input-element` class so that the input is sized correctly. 2. Triggering a state change event when the focus state changes so that the floating label is up-to-date. 3. Fixing an error being thrown inside `_shouldHideSeparator`. (cherry picked from commit 355233d)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves a few issues that were preventing the use of the range picker with an MDC-based
mat-form-field. Including:mat-mdc-input-elementclass so that the input is sized correctly._shouldHideSeparator.