Skip to content

refactor(cdk/testing): rename WebDriverHarnessEnvironment to SeleniumWebDriverHarnessEnvironment #22588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2021
Merged

refactor(cdk/testing): rename WebDriverHarnessEnvironment to SeleniumWebDriverHarnessEnvironment #22588

merged 1 commit into from
May 3, 2021

Conversation

mmalerba
Copy link
Contributor

No description provided.

@mmalerba mmalerba added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful target: rc This PR is targeted for the next release-candidate labels Apr 28, 2021
@mmalerba mmalerba requested a review from jelbourn April 28, 2021 22:09
@mmalerba mmalerba requested review from devversion and a team as code owners April 28, 2021 22:09
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 28, 2021
@mmalerba mmalerba added this to the 12.0.0 milestone Apr 28, 2021
jelbourn
jelbourn approved these changes Apr 29, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Apr 29, 2021
@annieyw annieyw merged commit ad3dc8a into angular:master May 3, 2021
annieyw pushed a commit that referenced this pull request May 3, 2021
@mmalerba @annieyw
refactor(cdk/testing): rename WebDriverHarnessEnvironment to (#22588)
aae0fec 
`SeleniumWebDriverHarnessEnvironment`

(cherry picked from commit ad3dc8a)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
12.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mmalerba @jelbourn @devversion @annieyw