Skip to content

refactor(material/schematics): fix some typos and add JSDoc #22610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2021
Merged

refactor(material/schematics): fix some typos and add JSDoc #22610

merged 1 commit into from
May 10, 2021

Conversation

Splaktar
Copy link
Contributor

@Splaktar Splaktar commented May 1, 2021

No description provided.

@Splaktar Splaktar requested a review from crisbeto May 1, 2021 05:11
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 1, 2021
@Splaktar Splaktar force-pushed the fix-theme-api-migration-typos branch from 58bc075 to a103967 Compare May 1, 2021 05:20
@Splaktar Splaktar changed the title chore(material/schematics): fix some typos and add JSDoc refactor(material/schematics): fix some typos and add JSDoc May 1, 2021
crisbeto
crisbeto approved these changes May 2, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Splaktar Splaktar added P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release labels May 2, 2021
@Splaktar Splaktar added the action: merge The PR is ready for merge by the caretaker label May 3, 2021
jelbourn
jelbourn approved these changes May 3, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added target: minor This PR is targeted for the next minor release target: patch This PR is targeted for the next patch release merge safe and removed target: patch This PR is targeted for the next patch release target: minor This PR is targeted for the next minor release labels May 7, 2021
@mmalerba
Copy link
Contributor

mmalerba commented May 7, 2021

@Splaktar needs rebase

@Splaktar Splaktar force-pushed the fix-theme-api-migration-typos branch from a103967 to 2d1f6f9 Compare May 7, 2021 08:27
@Splaktar
Copy link
Contributor Author

Splaktar commented May 7, 2021

@mmalerba done.

@mmalerba mmalerba added target: rc This PR is targeted for the next release-candidate and removed target: patch This PR is targeted for the next patch release labels May 10, 2021
@mmalerba mmalerba merged commit 6204f5f into angular:master May 10, 2021
mmalerba pushed a commit that referenced this pull request May 10, 2021
@Splaktar @mmalerba
refactor(material/schematics): fix some typos and add JSDoc (#22610)
7636cd8 
(cherry picked from commit 6204f5f)
@Splaktar Splaktar deleted the fix-theme-api-migration-typos branch May 10, 2021 20:47
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto crisbeto approved these changes

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P4 A relatively minor issue that is not relevant to core functions target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Splaktar @mmalerba @jelbourn @crisbeto @devversion