Skip to content

fix(material-experimental/mdc-slider): disable animations when noop module is included #22649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented May 9, 2021

Fixes that the MDC-based slider wasn't disabling its animations when noop animations are enabled.

Also removes some unused styles.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release labels May 9, 2021
@crisbeto crisbeto requested review from mmalerba and wagnermaciel May 9, 2021 11:05
@crisbeto crisbeto requested a review from devversion as a code owner May 9, 2021 11:05
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 9, 2021
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label May 11, 2021
@andrewseguin
Copy link
Contributor

Needs rebase

…odule is included

Fixes that the MDC-based slider wasn't disabling its animations when noop animations are enabled.
@crisbeto crisbeto force-pushed the mdc-slider-noop-animations branch from 1cd28ff to b3b25d4 Compare May 22, 2021 08:03
@crisbeto
Copy link
Member Author

Rebased.

@wagnermaciel wagnermaciel merged commit 89c8474 into angular:master May 25, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants