Skip to content

build: add animations toggle to the dev app #22669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2021
Merged

build: add animations toggle to the dev app #22669

merged 1 commit into from
May 12, 2021

Conversation

crisbeto
Copy link
Member

Adds a button that allows us to test noop animations without having to make code changes.

@crisbeto
build: add animations toggle to the dev app
a8b1502 
Adds a button that allows us to test noop animations without having to make code changes.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels May 12, 2021
@crisbeto crisbeto requested review from jelbourn and devversion May 12, 2021 04:52
@crisbeto crisbeto requested a review from mmalerba as a code owner May 12, 2021 04:52
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 12, 2021
@crisbeto crisbeto added target: minor This PR is targeted for the next minor release and removed cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release labels May 12, 2021
@google-cla

This comment has been minimized.

Sign in to view
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 12, 2021
jelbourn
jelbourn approved these changes May 12, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label May 12, 2021
@mmalerba mmalerba merged commit 14ee548 into angular:master May 12, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @devversion @mmalerba