Skip to content

Made slide-toggle label non user selectable #22756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2021
Merged

Made slide-toggle label non user selectable #22756

merged 1 commit into from
Jun 22, 2021

Conversation

tsndr
Copy link
Contributor

@tsndr tsndr commented May 22, 2021

Since checkbox labels aren't user-selectable, I've thought it would be a more consistent behavior if slide toggles aren't either.

@tsndr tsndr requested a review from devversion as a code owner May 22, 2021 13:48
@google-cla
Copy link

google-cla bot commented May 22, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label May 22, 2021
@tsndr
Copy link
Contributor Author

tsndr commented May 22, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels May 22, 2021
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI is failing because:

  1. You should use the user-select mixin from vendor-prefixes.
  2. The commit title isn't formatted correctly. It should start with fix(material/slide-toggle):.

@tsndr
Copy link
Contributor Author

tsndr commented May 23, 2021

Sorry, this is my first time contributing.

Thank you for clarifying, I've made the requested changes so we should be golden now.

@tsndr
Copy link
Contributor Author

tsndr commented May 23, 2021

I've noticed that CI still failed because my first commit still isn't formatted correctly. Do I have to make a new PR, or can I do anything else to fix it?

@crisbeto
Copy link
Member

You'll have to change the message on the first commit as well. Force pushing to rewrite it is allowed.

@tsndr
Copy link
Contributor Author

tsndr commented May 24, 2021

Alright, fixed it :)

Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Jun 20, 2021
@mmalerba mmalerba merged commit 9047985 into angular:master Jun 22, 2021
mmalerba pushed a commit that referenced this pull request Jun 22, 2021
mmalerba pushed a commit that referenced this pull request Jun 22, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants