-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Made slide-toggle label non user selectable #22756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI is failing because:
- You should use the
user-select
mixin fromvendor-prefixes
. - The commit title isn't formatted correctly. It should start with
fix(material/slide-toggle):
.
Sorry, this is my first time contributing. Thank you for clarifying, I've made the requested changes so we should be golden now. |
I've noticed that CI still failed because my first commit still isn't formatted correctly. Do I have to make a new PR, or can I do anything else to fix it? |
You'll have to change the message on the first commit as well. Force pushing to rewrite it is allowed. |
Alright, fixed it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(cherry picked from commit 9047985)
(cherry picked from commit 9047985)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Since checkbox labels aren't user-selectable, I've thought it would be a more consistent behavior if slide toggles aren't either.