Skip to content

Fixed incorrect theme variable used in theme file #22761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 25, 2021
Merged

Fixed incorrect theme variable used in theme file #22761

merged 3 commits into from
May 25, 2021

Conversation

ArcaneAj
Copy link
Contributor

@ArcaneAj ArcaneAj commented May 23, 2021

docs(material): Code specified in documentation will not compile

The code as written in step 4 won't compile, since $theme is not defined.
Should pass $my-theme instead.

@ArcaneAj ArcaneAj requested a review from jelbourn as a code owner May 23, 2021 10:19
@google-cla
Copy link

google-cla bot commented May 23, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label May 23, 2021
@ArcaneAj
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels May 23, 2021
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good, but the CI is failing due to the formatting of your commit's title. It should be prefixed with docs:.

@ArcaneAj ArcaneAj changed the title Fixed incorrect theme variable used in theme file docs: Fixed incorrect theme variable used in theme file May 23, 2021
@ArcaneAj ArcaneAj changed the title docs: Fixed incorrect theme variable used in theme file Fixed incorrect theme variable used in theme file May 23, 2021
@ArcaneAj
Copy link
Contributor Author

@crisbeto Is this correct?

@crisbeto
Copy link
Member

It seems like you tried to rename the PR which won't do anything. You have to rename the commit which can't be done through the GitHub UI.

Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release merge safe labels May 24, 2021
@wagnermaciel wagnermaciel added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels May 25, 2021
@wagnermaciel wagnermaciel merged commit 2600d4a into angular:master May 25, 2021
wagnermaciel pushed a commit that referenced this pull request May 25, 2021
* Corrected theme variable from $theme to $my-theme

(cherry picked from commit 2600d4a)
@wagnermaciel wagnermaciel added target: patch This PR is targeted for the next patch release and removed target: minor This PR is targeted for the next minor release labels May 25, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants