-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Fixed incorrect theme variable used in theme file #22761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good, but the CI is failing due to the formatting of your commit's title. It should be prefixed with docs:
.
@crisbeto Is this correct? |
It seems like you tried to rename the PR which won't do anything. You have to rename the commit which can't be done through the GitHub UI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Corrected theme variable from $theme to $my-theme (cherry picked from commit 2600d4a)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
docs(material): Code specified in documentation will not compile
The code as written in step 4 won't compile, since $theme is not defined.
Should pass $my-theme instead.