Skip to content

docs: clarify coordinate parameters for MatRipple.launch method. #22806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2021
Merged

docs: clarify coordinate parameters for MatRipple.launch method. #22806

merged 1 commit into from
May 28, 2021

Conversation

devversion
Copy link
Member

It was never clearly specified whether the coordinates for MatRipple.launch
should be relative to the trigger, ripple container or viewport, or even absolute.

This commit clarifies this by explicitly mentioning the viewport.

Fixes #16613.

@devversion
docs: clarify coordinate parameters for MatRipple.launch method.
9c3d8c5 
It was never clearly specified whether the coordinates for
`MatRipple.launch` should be relative to the trigger, ripple
container or viewport, or even absolute. This commit clarifies
this by explicitly mentioning the viewport.

Fixes angular#16613.
@devversion devversion added docs This issue is related to documentation target: patch This PR is targeted for the next patch release labels May 26, 2021
@devversion devversion requested review from jelbourn and crisbeto May 26, 2021 08:14
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 26, 2021
crisbeto
crisbeto approved these changes May 26, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label May 26, 2021
jelbourn
jelbourn approved these changes May 26, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmalerba mmalerba merged commit 3462c22 into angular:master May 28, 2021
mmalerba pushed a commit that referenced this pull request May 28, 2021
@devversion @mmalerba
docs: clarify coordinate parameters for MatRipple.launch method. (#…
8ea20e4 
…22806)

It was never clearly specified whether the coordinates for
`MatRipple.launch` should be relative to the trigger, ripple
container or viewport, or even absolute. This commit clarifies
this by explicitly mentioning the viewport.

Fixes #16613.

(cherry picked from commit 3462c22)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto crisbeto approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MatRipple.launch() coordinates are relative to viewport and not host element, contradicting the documentation.
4 participants
@devversion @jelbourn @crisbeto @mmalerba