Skip to content

build: filter out docs private members from interfaces #22831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2021
Merged

build: filter out docs private members from interfaces #22831

merged 1 commit into from
May 27, 2021

Conversation

crisbeto
Copy link
Member

Fixes that docs private members weren't being filtered out from interfaces.

Also moves the code around slightly so that we don't mutate the data inside Array.filter since the expectation is that the filter function is pure.

Fixes #20327.

@crisbeto
build: filter out docs private members from interfaces
0c84d2b 
Fixes that docs private members weren't being filtered out from interfaces.

Also moves the code around slightly so that we don't mutate the data inside `Array.filter` since the expectation is that the filter function is pure.

Fixes angular#20327.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent docs This issue is related to documentation merge safe target: patch This PR is targeted for the next patch release labels May 27, 2021
@crisbeto crisbeto requested a review from devversion May 27, 2021 19:13
@crisbeto crisbeto requested a review from a team as a code owner May 27, 2021 19:13
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 27, 2021
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label May 27, 2021
@mmalerba mmalerba merged commit d198cb5 into angular:master May 27, 2021
mmalerba pushed a commit that referenced this pull request May 27, 2021
@crisbeto @mmalerba
build: filter out docs private members from interfaces (#22831)
8d2c96c 
Fixes that docs private members weren't being filtered out from interfaces.

Also moves the code around slightly so that we don't mutate the data inside `Array.filter` since the expectation is that the filter function is pure.

Fixes #20327.

(cherry picked from commit d198cb5)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

About MatProgressSpinnerDefaultOptions#_forceAnimations definition
3 participants
@crisbeto @devversion @mmalerba