Skip to content

refactor(material/form-field): fix incorrectly named mixin base constant #22836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

With the recent changes to the mixins, a typo has sneaked into the
form-field mixin logic. This commit fixes that.

@devversion devversion added the target: minor This PR is targeted for the next minor release label May 28, 2021
@devversion devversion requested a review from crisbeto May 28, 2021 12:19
@devversion devversion requested a review from mmalerba as a code owner May 28, 2021 12:19
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 28, 2021
With the recent changes to the mixins, a typo has sneaked into the
form-field mixin logic. This commit fixes that.
@devversion devversion force-pushed the refactor/typo-form-field-mixin-base branch from 6347829 to d44be7a Compare May 28, 2021 12:25
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label May 28, 2021
@mmalerba mmalerba merged commit 5ad5c57 into angular:master Jun 2, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants