Skip to content

refactor(material/progress-spinner): refactor variable type to const in progress-spinner component unit tests #22841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2021
Merged

refactor(material/progress-spinner): refactor variable type to const in progress-spinner component unit tests #22841

merged 1 commit into from
Jun 1, 2021

Conversation

nitinmalave
Copy link
Contributor

Opening this PR as it is required to:

  • Refactor variables in progressive-spinner component unit tests to have constant type instead of let as this variables are not getting re-initialize during the test life-time.
  • All tests within a spec should be consistent with all other tests in file.

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 30, 2021
@nitinmalave nitinmalave changed the title refactor(material/progressive-spinner): refactor variable type to const in progressive-spinner component unit tests refactor(material/progress-spinner): refactor variable type to const in progress-spinner component unit tests May 30, 2021
@nitinmalave nitinmalave force-pushed the refactor-progressive-spinner-unit-tests branch from a1bbd29 to 0980480 Compare May 30, 2021 11:36
crisbeto
crisbeto approved these changes May 31, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker merge safe target: patch This PR is targeted for the next patch release labels May 31, 2021
@mmalerba mmalerba merged commit 0c33b2e into angular:master Jun 1, 2021
mmalerba pushed a commit that referenced this pull request Jun 1, 2021
@nitinmalave @mmalerba
refactor(material/progress-spinner): refactor variable type to const …
2895bd3 
…in progress-spinner component unit tests (#22841)

(cherry picked from commit 0c33b2e)
@nitinmalave nitinmalave deleted the refactor-progressive-spinner-unit-tests branch June 4, 2021 19:06
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nitinmalave @crisbeto @mmalerba