Skip to content

docs(material/checkbox): add description for properties in default options #22853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2021
Merged

docs(material/checkbox): add description for properties in default options #22853

merged 1 commit into from
Jun 1, 2021

Conversation

devversion
Copy link
Member

Developers can specify a color, or click action for all checkboxes using
MatCheckboxDefaultOptions. The properties for the default options are
currently not documented. This commit adds the missing descriptions.

@devversion devversion added docs This issue is related to documentation target: patch This PR is targeted for the next patch release labels Jun 1, 2021
@devversion devversion requested a review from andrewseguin June 1, 2021 14:09
@devversion devversion requested a review from jelbourn as a code owner June 1, 2021 14:09
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 1, 2021
@devversion devversion requested a review from crisbeto June 1, 2021 14:09
crisbeto
crisbeto approved these changes Jun 1, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Jun 1, 2021
@devversion
docs(material/checkbox): add description for properties in default op…
aecb503 
…tions

Developers can specify a color, or click action for all checkboxes using
`MatCheckboxDefaultOptions`. The properties for the default options are
currently not documented. This commit adds the missing descriptions.
@devversion devversion force-pushed the docs/checkbox-default-options branch from 33605e2 to aecb503 Compare June 1, 2021 14:40
@mmalerba mmalerba merged commit 5a2c495 into angular:master Jun 1, 2021
mmalerba pushed a commit that referenced this pull request Jun 1, 2021
@devversion @mmalerba
docs(material/checkbox): add description for properties in default op…
57cf5c4 
…tions (#22853)

Developers can specify a color, or click action for all checkboxes using
`MatCheckboxDefaultOptions`. The properties for the default options are
currently not documented. This commit adds the missing descriptions.

(cherry picked from commit 5a2c495)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devversion @crisbeto @mmalerba