Skip to content

test(material/button): refactor variable type to const in button component unit tests #22893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2021
Merged

test(material/button): refactor variable type to const in button component unit tests #22893

merged 1 commit into from
Jun 7, 2021

Conversation

nitinmalave
Copy link
Contributor

Opening this PR as it is required to:

  • Refactor variables in button component unit tests to have constant type instead of let as this variables are not getting re-initialize during the test life-time.
  • All tests within a spec should be consistent with all other tests in file.
  • Refactor variable name as per best coding practices.

@nitinmalave nitinmalave requested a review from jelbourn as a code owner June 4, 2021 19:16
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 4, 2021
crisbeto
crisbeto approved these changes Jun 6, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker merge safe target: patch This PR is targeted for the next patch release merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed labels Jun 6, 2021
@crisbeto
Copy link
Member

crisbeto commented Jun 6, 2021

Commit message fixup: should be test instead of refactor.

@nitinmalave nitinmalave force-pushed the refactor-button-component-unit-tests branch from 0555cee to 4b5519b Compare June 7, 2021 05:27
@nitinmalave
Copy link
Contributor Author

Hi @crisbeto, I fixed the commit message. Please have a look at PR.

@crisbeto crisbeto changed the title refactor(material/button): refactor variable type to const in button component unit tests test(material/button): refactor variable type to const in button component unit tests Jun 7, 2021
@crisbeto crisbeto removed the merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed label Jun 7, 2021
@andrewseguin andrewseguin merged commit fee2433 into angular:master Jun 7, 2021
andrewseguin pushed a commit that referenced this pull request Jun 7, 2021
@nitinmalave @andrewseguin
test(material/button): refactor variable type to const in button comp…
0844525 
…onent unit tests (#22893)

(cherry picked from commit fee2433)
@nitinmalave nitinmalave deleted the refactor-button-component-unit-tests branch June 7, 2021 21:22
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nitinmalave @crisbeto @andrewseguin