Skip to content

test(material/chips): refactor variable type to const in chips component unit tests #22898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2021
Merged

test(material/chips): refactor variable type to const in chips component unit tests #22898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/material/chips/chip-input.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ describe('MatChipInput', () => {
let inputDebugElement: DebugElement;
let inputNativeElement: HTMLElement;
let chipInputDirective: MatChipInput;
let dir = 'ltr';
const dir = 'ltr';

beforeEach(waitForAsync(() => {
TestBed.configureTestingModule({
Expand Down
74 changes: 37 additions & 37 deletions src/material/chips/chip-list.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,9 +188,9 @@ describe('MatChipList', () => {
});

it('should watch for chip focus', () => {
let array = chips.toArray();
let lastIndex = array.length - 1;
let lastItem = array[lastIndex];
const array = chips.toArray();
const lastIndex = array.length - 1;
const lastItem = array[lastIndex];

lastItem.focus();
fixture.detectChanges();
Expand Down Expand Up @@ -222,8 +222,8 @@ describe('MatChipList', () => {
describe('on chip destroy', () => {

it('should focus the next item', () => {
let array = chips.toArray();
let midItem = array[2];
const array = chips.toArray();
const midItem = array[2];

// Focus the middle item
midItem.focus();
Expand All @@ -237,9 +237,9 @@ describe('MatChipList', () => {
});

it('should focus the previous item', () => {
let array = chips.toArray();
let lastIndex = array.length - 1;
let lastItem = array[lastIndex];
const array = chips.toArray();
const lastIndex = array.length - 1;
const lastItem = array[lastIndex];

// Focus the last item
lastItem.focus();
Expand All @@ -253,8 +253,8 @@ describe('MatChipList', () => {
});

it('should not focus if chip list is not focused', () => {
let array = chips.toArray();
let midItem = array[2];
const array = chips.toArray();
const midItem = array[2];

// Focus and blur the middle item
midItem.focus();
Expand Down Expand Up @@ -317,12 +317,12 @@ describe('MatChipList', () => {
});

it('should focus previous item when press LEFT ARROW', () => {
let nativeChips = chipListNativeElement.querySelectorAll('mat-chip');
let lastNativeChip = nativeChips[nativeChips.length - 1] as HTMLElement;
const nativeChips = chipListNativeElement.querySelectorAll('mat-chip');
const lastNativeChip = nativeChips[nativeChips.length - 1] as HTMLElement;

let array = chips.toArray();
let lastIndex = array.length - 1;
let lastItem = array[lastIndex];
const array = chips.toArray();
const lastIndex = array.length - 1;
const lastItem = array[lastIndex];

// Focus the last item in the array
lastItem.focus();
Expand All @@ -338,11 +338,11 @@ describe('MatChipList', () => {
});

it('should focus next item when press RIGHT ARROW', () => {
let nativeChips = chipListNativeElement.querySelectorAll('mat-chip');
let firstNativeChip = nativeChips[0] as HTMLElement;
const nativeChips = chipListNativeElement.querySelectorAll('mat-chip');
const firstNativeChip = nativeChips[0] as HTMLElement;

let array = chips.toArray();
let firstItem = array[0];
const array = chips.toArray();
const firstItem = array[0];

// Focus the last item in the array
firstItem.focus();
Expand Down Expand Up @@ -406,12 +406,12 @@ describe('MatChipList', () => {
});

it('should focus previous item when press RIGHT ARROW', () => {
let nativeChips = chipListNativeElement.querySelectorAll('mat-chip');
let lastNativeChip = nativeChips[nativeChips.length - 1] as HTMLElement;
const nativeChips = chipListNativeElement.querySelectorAll('mat-chip');
const lastNativeChip = nativeChips[nativeChips.length - 1] as HTMLElement;

let array = chips.toArray();
let lastIndex = array.length - 1;
let lastItem = array[lastIndex];
const array = chips.toArray();
const lastIndex = array.length - 1;
const lastItem = array[lastIndex];

// Focus the last item in the array
lastItem.focus();
Expand All @@ -427,11 +427,11 @@ describe('MatChipList', () => {
});

it('should focus next item when press LEFT ARROW', () => {
let nativeChips = chipListNativeElement.querySelectorAll('mat-chip');
let firstNativeChip = nativeChips[0] as HTMLElement;
const nativeChips = chipListNativeElement.querySelectorAll('mat-chip');
const firstNativeChip = nativeChips[0] as HTMLElement;

let array = chips.toArray();
let firstItem = array[0];
const array = chips.toArray();
const firstItem = array[0];

// Focus the last item in the array
firstItem.focus();
Expand Down Expand Up @@ -480,12 +480,12 @@ describe('MatChipList', () => {
setupStandardList();
manager = chipListInstance._keyManager;

let nativeChips = chipListNativeElement.querySelectorAll('mat-chip');
let firstNativeChip = nativeChips[0] as HTMLElement;
const nativeChips = chipListNativeElement.querySelectorAll('mat-chip');
const firstNativeChip = nativeChips[0] as HTMLElement;

let RIGHT_EVENT = createKeyboardEvent('keydown', RIGHT_ARROW);
let array = chips.toArray();
let firstItem = array[0];
const RIGHT_EVENT = createKeyboardEvent('keydown', RIGHT_ARROW);
const array = chips.toArray();
const firstItem = array[0];

firstItem.focus();
expect(manager.activeItemIndex).toBe(0);
Expand Down Expand Up @@ -537,7 +537,7 @@ describe('MatChipList', () => {
describe('when the input has focus', () => {

it('should not focus the last chip when press DELETE', () => {
let nativeInput = fixture.nativeElement.querySelector('input');
const nativeInput = fixture.nativeElement.querySelector('input');

// Focus the input
nativeInput.focus();
Expand All @@ -552,7 +552,7 @@ describe('MatChipList', () => {
});

it('should focus the last chip when press BACKSPACE', () => {
let nativeInput = fixture.nativeElement.querySelector('input');
const nativeInput = fixture.nativeElement.querySelector('input');

// Focus the input
nativeInput.focus();
Expand Down Expand Up @@ -1307,7 +1307,7 @@ describe('MatChipList', () => {
});

it('sets the aria-describedby to reference errors when in error state', () => {
let hintId =
const hintId =
fixture.debugElement.query(By.css('.mat-hint'))!.nativeElement.getAttribute('id');
let describedBy = chipListEl.getAttribute('aria-describedby');

Expand All @@ -1317,7 +1317,7 @@ describe('MatChipList', () => {
fixture.componentInstance.formControl.markAsTouched();
fixture.detectChanges();

let errorIds = fixture.debugElement.queryAll(By.css('.mat-error'))
const errorIds = fixture.debugElement.queryAll(By.css('.mat-error'))
.map(el => el.nativeElement.getAttribute('id')).join(' ');
describedBy = chipListEl.getAttribute('aria-describedby');

Expand Down
6 changes: 3 additions & 3 deletions src/material/chips/chip-remove.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ describe('Chip Remove', () => {

describe('basic behavior', () => {
it('should apply a CSS class to the remove icon', () => {
let buttonElement = chipNativeElement.querySelector('button')!;
const buttonElement = chipNativeElement.querySelector('button')!;

expect(buttonElement.classList).toContain('mat-chip-remove');
});
Expand All @@ -49,7 +49,7 @@ describe('Chip Remove', () => {
});

it('should emit (removed) on click', () => {
let buttonElement = chipNativeElement.querySelector('button')!;
const buttonElement = chipNativeElement.querySelector('button')!;

testChip.removable = true;
fixture.detectChanges();
Expand All @@ -63,7 +63,7 @@ describe('Chip Remove', () => {
});

it('should not remove if parent chip is disabled', () => {
let buttonElement = chipNativeElement.querySelector('button')!;
const buttonElement = chipNativeElement.querySelector('button')!;

testChip.disabled = true;
testChip.removable = true;
Expand Down