Skip to content

chore: update test browsers to latest version #2297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2016
Merged

chore: update test browsers to latest version #2297

merged 1 commit into from
Dec 20, 2016

Conversation

devversion
Copy link
Member

  • Updates the Unit test browsers to the latest version on Saucelabs
  • No longer records videos & screenshots on the e2e mode, because this seems to slow the builds significant.

@devversion
chore: update test browsers to latest version
e8dbaeb 
* Updates the Unit test browsers to the `latest` version on Saucelabs
* No longer records videos & screenshots on the e2e mode, because this seems to slow the builds significant.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 20, 2016
@devversion devversion requested a review from jelbourn December 20, 2016 17:56
jelbourn
jelbourn reviewed Dec 20, 2016
View reviewed changes
test/protractor.conf.js

// By default Saucelabs tries to record the whole e2e run. This can slow down the builds.
'recordVideo': false,
'recordScreenshots': false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is okay for now, but eventually we'll want to turn screenshots back on.

jelbourn
jelbourn approved these changes Dec 20, 2016
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Dec 20, 2016
@jelbourn jelbourn merged commit dcfe0b0 into angular:master Dec 20, 2016
@devversion devversion deleted the chore/latest-browsers branch December 20, 2016 18:49
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devversion @jelbourn @googlebot