Skip to content

fix(material/datepicker): incorrect appearance when used in MDC form field #23028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2021
Merged

fix(material/datepicker): incorrect appearance when used in MDC form field #23028

merged 1 commit into from
Jun 22, 2021

Conversation

crisbeto
Copy link
Member

We were missing the mat-mdc-form-field-control class on the date range input which caused its start input to disappear, because it didn't have a line height.

@crisbeto
fix(material/datepicker): incorrect appearance when used in MDC form …
fb54a5c 
…field

We were missing the `mat-mdc-form-field-control` class on the date range input which caused its start input to disappear, because it didn't have a line height.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Jun 21, 2021
@crisbeto crisbeto requested a review from devversion June 21, 2021 05:49
@crisbeto crisbeto requested a review from mmalerba as a code owner June 21, 2021 05:49
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 21, 2021
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jun 21, 2021
@mmalerba mmalerba merged commit a049de4 into angular:master Jun 22, 2021
mmalerba pushed a commit that referenced this pull request Jun 22, 2021
@crisbeto @mmalerba
fix(material/datepicker): incorrect appearance when used in MDC form …
f9ea718 
…field (#23028)

We were missing the `mat-mdc-form-field-control` class on the date range input which caused its start input to disappear, because it didn't have a line height.

(cherry picked from commit a049de4)
mmalerba pushed a commit that referenced this pull request Jun 22, 2021
@crisbeto @mmalerba
fix(material/datepicker): incorrect appearance when used in MDC form …
7926ca1 
…field (#23028)

We were missing the `mat-mdc-form-field-control` class on the date range input which caused its start input to disappear, because it didn't have a line height.

(cherry picked from commit a049de4)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @devversion @mmalerba