Skip to content

fix(material/stepper): indicate to assistive technology when step is disabled #23090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2021
Merged

fix(material/stepper): indicate to assistive technology when step is disabled #23090

merged 1 commit into from
Jul 2, 2021

Conversation

crisbeto
Copy link
Member

Currently the stepper has no non-visual indication of whether a step is disabled. This is confusing, because selecting it won't do anything.

Fixes #23088.

@crisbeto
fix(material/stepper): indicate to assistive technology when step is …
d44fe5a 
…disabled

Currently the stepper has no non-visual indication of whether a step is disabled. This is confusing, because selecting it won't do anything.

Fixes angular#23088.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent Accessibility This issue is related to accessibility (a11y) target: patch This PR is targeted for the next patch release labels Jun 29, 2021
@crisbeto crisbeto requested a review from jelbourn June 29, 2021 15:22
@crisbeto crisbeto requested a review from mmalerba as a code owner June 29, 2021 15:22
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 29, 2021
mmalerba
mmalerba approved these changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Jun 29, 2021
@jelbourn jelbourn requested a review from amysorto June 30, 2021 20:22
jelbourn
jelbourn approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

amysorto
amysorto approved these changes Jun 30, 2021
View reviewed changes
Copy link
Contributor

@amysorto amysorto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewseguin andrewseguin merged commit 653f412 into angular:master Jul 2, 2021
andrewseguin pushed a commit that referenced this pull request Jul 2, 2021
@crisbeto @andrewseguin
fix(material/stepper): indicate to assistive technology when step is …
6a794ab 
…disabled (#23090)

Currently the stepper has no non-visual indication of whether a step is disabled. This is confusing, because selecting it won't do anything.

Fixes #23088.

(cherry picked from commit 653f412)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@amysorto amysorto amysorto approved these changes

@mmalerba mmalerba mmalerba approved these changes

Assignees
No one assigned
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(mat-stepper): a11y disabled state
5 participants
@crisbeto @jelbourn @amysorto @mmalerba @andrewseguin