Skip to content

refactor(material/tooltip): use overlay outside click tracking #23123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 6, 2021

Switches the tooltip to the outside click tracking from the OverlayRef, rather than having to maintain its own. This also results in fewer listeners on the body.

Switches the tooltip to the outside click tracking from the `OverlayRef`, rather than having to maintain its own. This also results in fewer listeners on the `body`.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jul 6, 2021
@crisbeto crisbeto requested a review from andrewseguin July 6, 2021 20:49
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 6, 2021
@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label Jul 15, 2021
@amysorto amysorto merged commit 81935ad into angular:master Jul 20, 2021
amysorto pushed a commit that referenced this pull request Jul 20, 2021
Switches the tooltip to the outside click tracking from the `OverlayRef`, rather than having to maintain its own. This also results in fewer listeners on the `body`.

(cherry picked from commit 81935ad)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants