-
Notifications
You must be signed in to change notification settings - Fork 6.8k
(docs): change progress-circle to progress-spinner #2313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
@@ -55,7 +55,7 @@ High level items planned for December 2016: | |||
| list | Available | [README][8] | [#107][0107] | | |||
| grid-list | Available | [README][9] | - | | |||
| icon | Available | [README][10] | - | | |||
| progress-circle | Available | [README][11] | - | | |||
| progress-spinner | Available | [README][11] | - | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you try to align the pipes in this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha, no problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
The CLA signed seems to be necessary here.
I signed the CLA prior to the pull request. Does it perhaps take some time to register? |
@alexisbmills The problem is that the commits aren't signed with the email you're using for GitHub and the CLA. |
Fix broken link and change docs to reflect renaming progress-circle to progress-spinner
CLAs look good, thanks! |
LGTM, thanks! |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fix broken link and change docs to reflect renaming progress-circle to progress-spinner