Skip to content

chore: move umd bundles to bundles directory #2316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2016

Conversation

devversion
Copy link
Member

  • Moves the generated .umd files to the bundles/ directory (as @angular/core)
  • Uses a gulp plugin for rollup because its more clear and also allows us to easily minify & create sourcemaps in the future

Note: After this PR, sourcemaps are no longer generated for the umd bundles.

  • This means that we also don't have sourcemaps for the demo-app (but those currently only map to the .js files)
  • I locally played with it and created a special check to create sourcemaps when being in development mode (but it was kind of overkill and unnecessary as mentioned above)

@jelbourn I was not sure what's the best way to go here. We'd need find a clear way how we want to structure our gulp tasks (because having X similar tasks just for release feels wrong to me)

Closes #2308

* Moves the generated `.umd` files to the `bundles/` directory (as @angular/core)
* Uses a gulp plugin for rollup because its more clear and also allows us to easily minify & create sourcemaps in the future
@devversion devversion requested a review from jelbourn December 21, 2016 10:14
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 21, 2016
@jelbourn
Copy link
Member

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Dec 21, 2016
@jelbourn jelbourn merged commit 965cd7a into angular:master Dec 21, 2016
@devversion devversion deleted the chore/bundles-folder branch December 21, 2016 18:18
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move umd bundles into bundles/ dir in npm package
3 participants