Skip to content

build: no longer install snapshot build of @angular/bazel #23429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

No longer uses a snapshot build for @angular/bazel. We
previously used a snapshot build in order to update to
v4 of rules_nodejs.

Also updates the versions while being at it.

@devversion devversion added merge safe target: major This PR is targeted for the next major release labels Aug 23, 2021
@devversion devversion requested a review from a team as a code owner August 23, 2021 14:18
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 23, 2021
No longer uses a snapshot build for `@angular/bazel`. We
previously used a snapshot build in order to update to
v4 of `rules_nodejs`.
@devversion devversion force-pushed the build/remove-angular-bazel-workaround branch from eeee53a to 198553a Compare August 23, 2021 14:44
@devversion devversion requested a review from jelbourn as a code owner August 23, 2021 14:44
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sets up the jsonc-parser dependency in the BUILD bazel file.
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Aug 23, 2021
@amysorto amysorto merged commit e9091fe into angular:master Aug 23, 2021
devversion added a commit to devversion/material2 that referenced this pull request Aug 25, 2021
…23429)

* build: no longer install snapshot build of `@angular/bazel`

No longer uses a snapshot build for `@angular/bazel`. We
previously used a snapshot build in order to update to
v4 of `rules_nodejs`.

* build: add missing dependency for jsonc-parser

Sets up the jsonc-parser dependency in the BUILD bazel file.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants