Skip to content

Patch port of various build changes #23440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 25, 2021
Merged

Conversation

devversion
Copy link
Member

Updates the shared dev-infra package to take advanatge
of recent improvements for the release tool.

This also fixes the issue where the merge tooling requires
the `breaking change` label, while there also is the
`state: breaking change` label. The ng-dev tool no longer
accepts custom configuration of that label.

Also the merge configuration no longer accepts custom labels,
in order to achieve consistent labeling as specified in the
Angular versioning/branching/labeling spec.
Checks the `.ng-dev` tool configuration in CI, compared
to doing it locally when the caretaker intends to perform
a merge and then realizes the config is broken.
Removes the legacy release tooling from the repository. We
had two successful releases with the new tool, and the tool
has been used for quite a while in the framework repository.

We will fix issues in the new release tool going forward.
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 25, 2021
@devversion devversion added action: merge The PR is ready for merge by the caretaker merge safe target: patch This PR is targeted for the next patch release labels Aug 25, 2021
@devversion devversion marked this pull request as ready for review August 25, 2021 17:02
@devversion devversion requested review from jelbourn and a team as code owners August 25, 2021 17:02
No longer uses a snapshot build for `@angular/bazel`. We
previously used a snapshot build in order to update to
v4 of `rules_nodejs`.
Sets up the jsonc-parser dependency in the BUILD bazel file.
@devversion devversion requested a review from amysorto August 25, 2021 17:47
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@amysorto amysorto merged commit ca2693b into angular:12.2.x Aug 25, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants