Skip to content

build: add exports entry for cdk schematics utilities #23731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

clydin
Copy link
Member

@clydin clydin commented Oct 11, 2021

An exports entry within the @angular/cdk package for the schematics utilities has been added. This entry is required for the schematics present in the @angular/material package to function. @angular/material schematics leverage a variety of the utilities and helper functions within @angular/cdk/schematics.
This change was successfully tested against the latest -next release of the Angular CLI via ng add @angular/material.

An `exports` entry within the `@angular/cdk` package for the schematics utilities has been added. This entry is required for the schematics present in the `@angular/material` package to function. `@angular/material` schematics leverage a variety of the utilities and helper functions within `@angular/cdk/schematics`.
@clydin clydin requested a review from jelbourn as a code owner October 11, 2021 20:18
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 11, 2021
@clydin clydin added target: rc This PR is targeted for the next release-candidate area: cdk/schematics cdk/schematics is *not* a public API area: build & ci Related the build and CI infrastructure of the project labels Oct 11, 2021
Copy link
Contributor

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker merge safe labels Oct 11, 2021
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of that!

@devversion devversion added the P2 The issue is important to a large percentage of users, with a workaround label Oct 11, 2021
@zarend zarend merged commit fb36143 into angular:master Oct 12, 2021
zarend pushed a commit that referenced this pull request Oct 12, 2021
An `exports` entry within the `@angular/cdk` package for the schematics utilities has been added. This entry is required for the schematics present in the `@angular/material` package to function. `@angular/material` schematics leverage a variety of the utilities and helper functions within `@angular/cdk/schematics`.

(cherry picked from commit fb36143)
@clydin clydin deleted the esm/schematics-endpoints branch October 12, 2021 09:57
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project area: cdk/schematics cdk/schematics is *not* a public API cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants