Skip to content

fix(cdk/schematics): drop tilde imports when updating to v13 #23732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2021

Conversation

crisbeto
Copy link
Member

Tilde imports have been deprecated in the Sass loader for a long time and they won't work with the new package format in v13. These changes add a migration that will drop the tilde.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround merge safe target: rc This PR is targeted for the next release-candidate labels Oct 12, 2021
@crisbeto crisbeto requested a review from devversion October 12, 2021 06:48
@crisbeto crisbeto requested a review from jelbourn as a code owner October 12, 2021 06:48
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 12, 2021
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. Just one suggestion on also migrating CSS files.

Tilde imports have been deprecated in the Sass loader for a long time and they won't work with the new package format in v13. These changes add a migration that will drop the tilde.
@crisbeto crisbeto force-pushed the tilde-import-migration branch from 7e4ef20 to 8b2530a Compare October 12, 2021 13:51
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Oct 12, 2021
@zarend zarend merged commit 8d4b056 into angular:master Oct 13, 2021
zarend pushed a commit that referenced this pull request Oct 13, 2021
Tilde imports have been deprecated in the Sass loader for a long time and they won't work with the new package format in v13. These changes add a migration that will drop the tilde.

(cherry picked from commit 8d4b056)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants