refactor: fix examples not recognizing webcontainer stackblitz instances #23901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes that examples do not properly recognize webcontainer Stackblitz instances. This causes some sidenav examples to not even work within Stackblitz as a message `Please open on Stackblitz` is displayed. Fixes angular#23895.
devversion
added
P2
google-cla
bot
added
the
cla: yes
|
In the future, we could technically embed Stackblitz projects for these examples, so that users would not need to go to Stackblitz at all.. Not exactly sure about the problem sidenav examples though.. |
|
Just a note: From some brief experiments, it looks like we could serve these examples directly in the docs by forming a new containing block (i.e. by using a |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that examples do not properly recognize webcontainer Stackblitz
instances. This causes some sidenav examples to not even work within
Stackblitz as a message
Please open on Stackblitzis displayed.Fixes #23895.